Feature/target soft delete #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowal
reviewed
Sep 20, 2019
app/admin/target_scopes.rb
Outdated
|
|
||
| controller do | ||
| def destroy | ||
| destroy_command = ::Command::Destroy::TargetScope.new(resource) |
There was a problem hiding this comment.
Maybe it's worth to extract this whole action to some module (parametrized with resource class). It looks like it won't change much anymore.
There was a problem hiding this comment.
@kowal added DiscardableController. Also moved DiscardableModel to concerns. Take a look please
kowal
reviewed
Sep 23, 2019
| # Redirect to resource list with proper message | ||
| def destroy | ||
| entity_name = ActiveSupport::Inflector.singularize(controller_name).camelize | ||
| entity_destroy_class = "::Command::Destroy::#{entity_name}".constantize |
There was a problem hiding this comment.
can we catch possible NameErrors here and re-throw ex with more context?
kowal
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.