Feature/documents #8
Conversation
| @@ -16,4 +16,12 @@ def summary | |||
| def core_objective | |||
| model.core_objective.html_safe | |||
| end | |||
|
|
|||
| def document_list | |||
tsubik
force-pushed
the
feature/documents
branch
from
1048bf9
to
42739fb
Compare
app/decorators/document_decorator.rb
Outdated
| class DocumentDecorator < Draper::Decorator | ||
| delegate_all | ||
|
|
||
| def name_link |
There was a problem hiding this comment.
what do you think about renaming those methods ..
name_link => document_page_link (or just document_link)
open_link => document_url_link
.. to indicate where those links actually go.
| @@ -0,0 +1,16 @@ | |||
| class UrlValidator < ActiveModel::EachValidator | |||
| def validate_each(record, attribute, value) | |||
| return unless value.present? | |||
There was a problem hiding this comment.
could we combine return unless value.present? and ..unless url_valid?(value) in single condition?
There was a problem hiding this comment.
Sure, I will make two separate guard clauses. I think 2 will be more readable.
app/validators/url_validator.rb
Outdated
| end | ||
|
|
||
| def url_valid?(url) | ||
| url = begin |
There was a problem hiding this comment.
I think url = URI.parse(url) rescue false would be enough here
There was a problem hiding this comment.
Rubocop changed that automagically.
There was a problem hiding this comment.
ok, let's not mess with RuboCop 🤖
There was a problem hiding this comment.
I already did. lol. I don't like that rule
| this.wrapperClass = this.data.get('wrapperClass') || 'nested-fields'; | ||
| } | ||
|
|
||
| addRecord(event) { |
There was a problem hiding this comment.
This code here looks like it shouldn't be directly related with "documents", rather, it is more like generic add/remove resource logic, right?
There was a problem hiding this comment.
You are right. I will change that
The first iteration of documents upload added to Litigations
Document could be
TODO