Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert parser to Cython #29

Open
Vlek opened this issue Feb 11, 2021 · 2 comments
Open

Convert parser to Cython #29

Vlek opened this issue Feb 11, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Vlek
Copy link
Owner

Vlek commented Feb 11, 2021

Attempt to increase the speed of the script by converting the underlying parser/evaluator to Citron for a hopefully decent speed boost. Current tests take ~0.50ms to complete. I wonder if I can halve that time.

@Vlek Vlek added the enhancement New feature or request label Feb 11, 2021
@Vlek Vlek self-assigned this Feb 11, 2021
@Vlek
Copy link
Owner Author

Vlek commented Feb 12, 2021

@Vlek
Copy link
Owner Author

Vlek commented Jul 15, 2021

I think we should take a good look at our speed and memory usage statistics in our speed metric tests in #41 and really consider whether this is the bottleneck. I believe that it is pretty fair to say that this begins to become a bottleneck when it's the case that we have thousands of dice rolls, but with regular usage it is unlikely to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant