Added implementation and (mediocre) tests for editing an element

build.gradle

@@ -18,6 +18,8 @@ repositories {
 dependencies {
     compile group: 'commons-collections', name: 'commons-collections', version: '3.2'
     compile group: 'org.jdom', name: 'jdom2', version: '2.0.6'
+    // xPath dependency
+    compile group: 'jaxen', name: 'jaxen', version: '1.1.6' 
     testCompile group: 'junit', name: 'junit', version: '4.+'
     testCompile 'org.mockito:mockito-all:2.0.2-beta'
 

src/main/java/de/vogel612/helper/ui/OverviewModel.java

@@ -12,4 +12,8 @@ public interface OverviewModel {
 	void loadFromDirectory(Path resxFolder, String targetLocale);
 
 	List<Translation> getTranslations();
+
+	void updateTranslation(String key, String newTranslation);
+
+	void saveTranslation();
 }

src/main/java/de/vogel612/helper/ui/impl/OverviewModelImpl.java

@@ -16,7 +16,10 @@
 import org.jdom2.Document;
 import org.jdom2.Element;
 import org.jdom2.JDOMException;
+import org.jdom2.filter.Filters;
 import org.jdom2.input.SAXBuilder;
+import org.jdom2.xpath.XPathExpression;
+import org.jdom2.xpath.XPathFactory;
 
 import de.vogel612.helper.data.Translation;
 import de.vogel612.helper.ui.OverviewModel;
@@ -61,6 +64,7 @@ public class OverviewModelImpl implements OverviewModel {
 			this.presenter.onException(e, "Something went really wrong");
 		}
 	};
+	private final XPathFactory xPathFactory = XPathFactory.instance();
 
 	private OverviewPresenter presenter;
 	private Document translationDocument;
@@ -142,4 +146,26 @@ public List<Translation> getTranslations() {
 		}).collect(Collectors.toList());
 	}
 
+	@Override
+	public void updateTranslation(final String key, final String newTranslation) {
+		// XPathExpression<Element> expression =
+		// xPathFactory.compile("/parent::"
+		// + ELEMENT_NAME + "/@" + KEY_NAME + "='" + key + "'",
+		// Filters.element());
+
+		XPathExpression<Element> expression = xPathFactory.compile("/*/"
+				+ ELEMENT_NAME + "[@" + KEY_NAME + "='" + key + "']/"
+				+ VALUE_NAME, Filters.element());
+		// ohh damn that's so many assumptions
+		Element translationToUpdate = expression.evaluate(translationDocument)
+				.get(0);
+		translationToUpdate.setText(newTranslation);
+	}
+
+	@Override
+	public void saveTranslation() {
+		// TODO Auto-generated method stub
+
+	}
+
 }

src/test/java/de/vogel612/helper/ui/OverviewModelTest.java

@@ -5,6 +5,7 @@
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.doThrow;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.reset;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
 
@@ -29,6 +30,10 @@ public class OverviewModelTest {
 		new Translation("TestKey1", "TestValue", "Second Test"),
 		new Translation("TestKey2", "Another Test Value", "Another Test Value")
 	};
+	private static final Translation[] expectedAfterEdit = {
+		new Translation("TestKey1", "TestValue", "New Translation"),
+		new Translation("TestKey2", "Another Test Value", "Another Test Value")
+	};
 
 	private OverviewModelImpl cut;
 	private OverviewPresenter p;
@@ -76,7 +81,6 @@ public void loadFromFile_andSuccessiveGet_returnCorrectInformation() {
 		assertArrayEquals(expected, translations);
 	}
 
-	// FIXME: Test normalization!
 	@Test
 	public void loadFromFile_normalizationWorksAsExpected() {
 		final CountDownLatch latch = new CountDownLatch(1);
@@ -114,4 +118,18 @@ public void loadFromFile_normalizationWorksAsExpected() {
 
 		assertArrayEquals(expected2, translations);
 	}
+
+	@Test
+	public void editTranslation_updatesDocument() {
+		// abusing the loading test as a setup...
+		loadFromFile_andSuccessiveGet_returnCorrectInformation();
+		reset(p); // just to be sure
+
+		cut.updateTranslation("TestKey1", "New Translation");
+
+		Translation[] translations;
+		translations = cut.getTranslations().toArray(new Translation[0]);
+
+		assertArrayEquals(expectedAfterEdit, translations);
+	}
 }