Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a script to pull the IPs of all the relays to your docker node #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cswenor
Copy link

@cswenor cswenor commented Jan 22, 2024

No description provided.

Copy link
Contributor

@hsoerensen hsoerensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is opportunity to make a couple of improvements here:

  • netstat may not be installed on all distributions. It's part of net-tools which on Ubuntu is not a default package.
  • nsenter do require root to execute

We can improve by

  • Installing netstat on-demand
  • Ensure that the script runs as sudo if user id != 0

The main install.sh file do contain logic for running as sudo, as we could either duplicate here, or modularize certain components by extracting and then using source to bring them into scope (unless there's better options ofc) across the various files, doing this would req. an assembly step for the install.sh file (due download nature), however it could benefit us by also allowing us to more easily adopt and introduce shunit2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants