feat: retrieve impact reports #10

baumstern · 2024-01-20T01:01:09Z

Changes

Implemented a new feature to fetch existing impact reports from the Graph and IPFS via the Hypercert SDK. This is now available at the /impact-reports endpoint.

Future Work:

Properly define Report model
Implement server-side updates for newly added reports

thebeyondr

hey, please use functional programming tools over object-oriented ones. look into using functions, types and hooks instead of creating classes, models and controllers.

thebeyondr · 2024-01-22T06:46:04Z

app/routes/hypercert-reports.server..tsx

@baumstern waddup so I remade the connector in a functional way since I randomly woke up at midnight🤷🏽‍♂️. Feel free to edit as you please. I haven't removed any of your code so feel free to update that as needed. thanks for laying the foundation. This also isn't tested yet and needs to be before merging!

@CJ-Rose please assess this as well, and let me know if any questions/insights arise

The idea is that this acts as a resource route in Remix. Other UI routes can call /hypercert-reports and get data back

Re-add daehyuns hypercert documentation comments for gql

Setup UI to get data and cache it in session

IPFS speed check, it was slow even for hypercert docs (so is it viable to retrieve report data from it? hmmmm)

go back to sleep

thanks for jumping in with the code! quick question: How's the caching handled with the functional approach? Used a singleton in my version to cut down on Graph/IPFS requests

caching isn't handled rn, thats the responsibility of the client. This is just responsible for returning that data.

Re: limiting requests, I'm sure there was still a loop fetching the metadata for each claim so it wasn't like a batched thing. How does a singleton help us batch requests? Also, can you point me to the singleton implementation?

caching isn't handled rn, thats the responsibility of the client. This is just responsible for returning that data.

Re: limiting requests, I'm sure there was still a loop fetching the metadata for each claim so it wasn't like a batched thing. How does a singleton help us batch requests? Also, can you point me to the singleton implementation?

server-side caching decouples the client from external services (such as Graph and IPFS), reducing redundant calls to these services. It retrieves and stores data upon instantiation.

It had implemented using static keyword:

dc5e641#diff-3d7ef1b624b061d38b0608ad49c35092d267df101e1122eacfc44fc77b3339ceR8

dc5e641#diff-3d7ef1b624b061d38b0608ad49c35092d267df101e1122eacfc44fc77b3339ceR21

Actually, I've scrapped the class implementation and replaced it with a module-scope variable, as it preserves data until the server process terminates. It's neater – thanks for the suggestion

server-side caching decouples the client from external services (such as Graph and IPFS), reducing redundant calls to these services. It retrieves and stores data upon instantiation.

hmm, a few things:

How do we allow the server cache to expire or tell it to fetch new data?

I don't think this subverts the need for client-side caching. we need them both - what do you think?

What type of test would allow us to verify that your implementation actually caches?

server-side caching decouples the client from external services (such as Graph and IPFS), reducing redundant calls to these services. It retrieves and stores data upon instantiation.

hmm, a few things:

1. How do we allow the server cache to expire or tell it to fetch new data? 2. I don't think this subverts the need for client-side caching. we need them both - what do you think? 3. What type of test would allow us to verify that your implementation actually caches?

the server should be notified when a Hypercert is minted, so it can update the entry

sure, they serve different purposes

I will add a test case

awesome, thanks for your efforts so far. we're closer now 🫡

I can't believe this was posted today, as we're talking about cache. 💥

https://youtu.be/RXMvnqb7A8k

I can't believe this was posted today, as we're talking about cache. 💥

https://youtu.be/RXMvnqb7A8k

Is he Big Brother? 🤔🤔

baumstern · 2024-01-22T15:20:21Z

hey, please use functional programming tools over object-oriented ones. look into using functions, types and hooks instead of creating classes, models and controllers.

main focus here was just nailing the functionality. But exploring functional programming now seems like a cool idea too -- I gotta say good bye to old school ways

thebeyondr · 2024-01-22T16:35:53Z

main focus here was just nailing the functionality. But exploring functional programming now seems like a cool idea too -- I gotta say good bye to old school ways

np, I just find functional programming ends up less buggy and verbose

baumstern · 2024-01-23T04:45:05Z

@thebeyondr added tests, please take another look!

thebeyondr

just a few small things then we're good!

thebeyondr · 2024-01-26T15:48:42Z

package.json

@@ -7,13 +7,15 @@
    "build": "remix vite:build",
    "dev": "remix vite:dev",
    "start": "remix-serve ./build/server/index.js",
+    "test": "vitest",
    "lint": "biome check --apply ./app",


can we remove this?

Removed in 6373f32

thebeyondr · 2024-01-26T15:48:56Z

package.json

@@ -30,6 +32,7 @@
  "devDependencies": {
    "@biomejs/biome": "1.5.1",
    "@remix-run/dev": "^2.5.0",


can we remove this?

oh actually it's used in vite.config.ts

thebeyondr · 2024-01-26T15:51:45Z

docs/server.md

@@ -0,0 +1,24 @@
+# Server Design


why is this here and not in README?

Moved to README.md in 6373f32

thebeyondr

lfg

baumstern requested review from thebeyondr and CJ-Rose January 20, 2024 01:01

baumstern force-pushed the hc branch from eb3620c to dc5e641 Compare January 20, 2024 01:05

thebeyondr requested changes Jan 21, 2024

View reviewed changes

thebeyondr reviewed Jan 22, 2024

View reviewed changes

thebeyondr assigned baumstern and thebeyondr Jan 22, 2024

thebeyondr added the feature 🚀 New feature or request label Jan 22, 2024

baumstern and others added 2 commits January 23, 2024 03:13

feat: implement minimal server

20f5602

refactor: ♻️ Add Hypercert reports server route and Report interface

f4abd31

baumstern force-pushed the hc branch 2 times, most recently from b6074aa to 029eb95 Compare January 23, 2024 04:42

baumstern force-pushed the hc branch 4 times, most recently from afc3b7c to 68779c6 Compare January 26, 2024 00:03

baumstern changed the title ~~feat: implement minimal server~~ feat: retrieve impact reports Jan 26, 2024

baumstern mentioned this pull request Jan 26, 2024

fix/load hypercerts from root #13

Closed

thebeyondr requested changes Jan 26, 2024

View reviewed changes

baumstern force-pushed the hc branch from 68779c6 to 6373f32 Compare January 26, 2024 21:30

feat: update Report type

0c92120

baumstern force-pushed the hc branch from 6373f32 to 0c92120 Compare January 26, 2024 21:33

Delete docs directory

53366a4

thebeyondr approved these changes Jan 27, 2024

View reviewed changes

thebeyondr merged commit 0f21312 into VoiceDeck:main Jan 27, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: retrieve impact reports #10

feat: retrieve impact reports #10

baumstern commented Jan 20, 2024 •

edited

Loading

thebeyondr left a comment

thebeyondr Jan 22, 2024 •

edited

Loading

baumstern Jan 22, 2024

thebeyondr Jan 22, 2024 •

edited

Loading

baumstern Jan 22, 2024

baumstern Jan 22, 2024

thebeyondr Jan 22, 2024

baumstern Jan 22, 2024

thebeyondr Jan 22, 2024

thebeyondr Jan 23, 2024

baumstern Jan 23, 2024

baumstern commented Jan 22, 2024

thebeyondr commented Jan 22, 2024

baumstern commented Jan 23, 2024

thebeyondr left a comment

thebeyondr Jan 26, 2024

baumstern Jan 26, 2024

thebeyondr Jan 26, 2024

baumstern Jan 26, 2024

thebeyondr Jan 26, 2024

baumstern Jan 26, 2024

thebeyondr left a comment

feat: retrieve impact reports #10

feat: retrieve impact reports #10

Conversation

baumstern commented Jan 20, 2024 • edited Loading

Changes

thebeyondr left a comment

Choose a reason for hiding this comment

thebeyondr Jan 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thebeyondr Jan 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baumstern commented Jan 22, 2024

thebeyondr commented Jan 22, 2024

baumstern commented Jan 23, 2024

thebeyondr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thebeyondr left a comment

Choose a reason for hiding this comment

baumstern commented Jan 20, 2024 •

edited

Loading

thebeyondr Jan 22, 2024 •

edited

Loading

thebeyondr Jan 22, 2024 •

edited

Loading