-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/install and style button #12
Conversation
…k colors there is a possible naming issue where i needed to use vd-text-blue for the button bg
Your Render PR Server URL is https://voicedeck-pr-12.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cmpeb1mv3ddc73dkm7mg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the primary button background is vd-text-blue. using this var as the background could be confusing.
@CJ-Rose can we update the token to be something else? I'd prefer if colors were named neutrally (not text or component based)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the primary button background is vd-text-blue. using this var as the background could be confusing.
@CJ-Rose can we update the token to be something else? I'd prefer if colors were named neutrally (not text or component based)
yep. originally i gave them different names bc the text color is "Cloud burst" while the accents are all named as degrees of "Gothic" in the figma. but since the darkest "Gothic" shade being used is 700, i think its fine to change vd-text-blue
to vd-blue-900
Sounds good. I'm happy to make that change in this PR. |
…-blue to vd-blue-900
installed button from https://ui.shadcn.com/docs/components/button
updated styles for button to match figma. Since we did not have design for all button variants I improvised following the pattern from replacing the other color values. I will follow up with Chiali to review and confirm.
Note: the primary button background is vd-text-blue. using this var as the background could be confusing.