Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/install and style button #12

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Feat/install and style button #12

merged 4 commits into from
Jan 30, 2024

Conversation

0xRowdy
Copy link
Contributor

@0xRowdy 0xRowdy commented Jan 25, 2024

installed button from https://ui.shadcn.com/docs/components/button
updated styles for button to match figma. Since we did not have design for all button variants I improvised following the pattern from replacing the other color values. I will follow up with Chiali to review and confirm.

Note: the primary button background is vd-text-blue. using this var as the background could be confusing.

Screenshot 2024-01-25 at 3 43 20 PM

…k colors

there is a possible naming issue where i needed to use vd-text-blue for the button bg
Copy link

render bot commented Jan 25, 2024

@thebeyondr thebeyondr added the feature 🚀 New feature or request label Jan 26, 2024
Copy link
Collaborator

@thebeyondr thebeyondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the primary button background is vd-text-blue. using this var as the background could be confusing.

@CJ-Rose can we update the token to be something else? I'd prefer if colors were named neutrally (not text or component based)

Copy link
Collaborator

@CJ-Rose CJ-Rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the primary button background is vd-text-blue. using this var as the background could be confusing.

@CJ-Rose can we update the token to be something else? I'd prefer if colors were named neutrally (not text or component based)

yep. originally i gave them different names bc the text color is "Cloud burst" while the accents are all named as degrees of "Gothic" in the figma. but since the darkest "Gothic" shade being used is 700, i think its fine to change vd-text-blue to vd-blue-900

@0xRowdy
Copy link
Contributor Author

0xRowdy commented Jan 26, 2024

Note: the primary button background is vd-text-blue. using this var as the background could be confusing.

@CJ-Rose can we update the token to be something else? I'd prefer if colors were named neutrally (not text or component based)

yep. originally i gave them different names bc the text color is "Cloud burst" while the accents are all named as degrees of "Gothic" in the figma. but since the darkest "Gothic" shade being used is 700, i think its fine to change vd-text-blue to vd-blue-900

Sounds good. I'm happy to make that change in this PR.

@0xRowdy 0xRowdy merged commit 455c34c into main Jan 30, 2024
3 checks passed
@0xRowdy 0xRowdy deleted the feat/intall-and-style-button branch January 30, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants