Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/global footer #24

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Feat/global footer #24

merged 8 commits into from
Feb 7, 2024

Conversation

0xRowdy
Copy link
Contributor

@0xRowdy 0xRowdy commented Feb 6, 2024

Created mobile and desktop variants of the global footer.

Screenshot 2024-02-06 at 9 51 15 AM Screenshot 2024-02-06 at 9 52 13 AM Screenshot 2024-02-06 at 9 52 18 AM

Copy link

render bot commented Feb 6, 2024

@0xRowdy
Copy link
Contributor Author

0xRowdy commented Feb 6, 2024

Note: I pulled in the global-nav to gain access to the logo asset.

@CJ-Rose
Copy link
Collaborator

CJ-Rose commented Feb 6, 2024

@0xRowdy is this one ready to review?

@0xRowdy
Copy link
Contributor Author

0xRowdy commented Feb 7, 2024

@0xRowdy is this one ready to review?

Yeah, but it has the stuff for the header in it so it looks larger than it is. I'll request you guys to review it as soon as the nav PR gets merged in.

Copy link
Collaborator

@CJ-Rose CJ-Rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@0xRowdy 0xRowdy merged commit 2edc033 into main Feb 7, 2024
3 checks passed
@thebeyondr
Copy link
Collaborator

guys how did this merge when my terminal was yelling at me about missing key props? (Fixed in #25 )
image

@0xRowdy 0xRowdy deleted the feat/global-footer branch March 5, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants