Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target annotation handling #6

Closed
Voiteh opened this issue Jun 21, 2019 · 1 comment
Closed

Target annotation handling #6

Voiteh opened this issue Jun 21, 2019 · 1 comment
Assignees
@Voiteh
Labels
Enhancement New feature or request Priority High High priority issue
Milestone
First release

Comments

@Voiteh
Copy link
Owner

Voiteh commented Jun 21, 2019

Probably target annotations are fucked up right now as no unit tests are available. We need to allow selecting of constructors for injection of targets
@Voiteh Voiteh added Bug Something isn't working Enhancement New feature or request Priority High High priority issue labels Jun 21, 2019
@Voiteh Voiteh added this to the First release milestone Jun 21, 2019
@Voiteh Voiteh self-assigned this Jun 21, 2019
@Voiteh Voiteh added this to Version 0.0 in Depin Core Jun 21, 2019
@Voiteh Voiteh removed the Bug Something isn't working label Jun 22, 2019
@Voiteh
Copy link
Owner Author

Voiteh commented Jun 22, 2019

Seems that it is working...ish We have issue with Ceylon retrieval of annotations from constructor parameters so there is workaround for the issue eclipse-archived/ceylon#7448 . Only default named parameters will work.

Voiteh added a commit that referenced this issue Jun 22, 2019
@Voiteh
Unit tests for target annotations selection, workaround for ceylon bug …
5bbb874 
…eclipse-archived/ceylon#7448 (#6)
@Voiteh Voiteh mentioned this issue Jun 22, 2019
Merged
@Voiteh Voiteh closed this as completed Jun 22, 2019
@Voiteh Voiteh reopened this Jun 22, 2019
Voiteh added a commit that referenced this issue Jun 23, 2019
@Voiteh
Fix target constructors finiding, fix tests (#6)
263be21
Voiteh added a commit that referenced this issue Jun 23, 2019
@Voiteh
Merge pull request #21 from Voiteh/issue/6
09e2975 
Fix target constructors finiding, fix tests (#6)
@Voiteh Voiteh closed this as completed Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Voiteh Voiteh

Labels
Enhancement New feature or request Priority High High priority issue
Projects
None yet
Milestone
First release
Development

No branches or pull requests
1 participant
@Voiteh