-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User config #10
User config #10
Conversation
Thanks for PR. I generally like that idea and will take a look at it soon. |
Did you have time to look at it. Do you want me to redo it for the zimbra-v8.7_dev branch? |
@@ -0,0 +1,2 @@ | |||
*~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer this in your personal gitignore, but alright, why not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It excludes temporary saves from some text editors. Never heard of someone having a problem with this rule in production. Never saw filename~
used for anything else than temporary files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your editor does it, it should be in your personal gitignore. Otherwise you can have it in all of your repositories. I have configured my vim to save it to ~/.vim/backup
to not spam the file system with bogus files.
But whatever, I merged it.
I merge the changes to Thanks for PR. Please, review my merge changes - they are mentioned in the commit message. |
I would like to integrate the domains and email into the config so that you don't need to change cron or your systemd timer if you change these options. E.g.
I am not sure how to integrate that into the script. I don't see how you handle $2 etc. |
You're right. I had some ideas but it doesn't make sense anymore. It should be in config file and there are no needs for script parameters anymore. |
Hi @lightonflux I moved the email and common name to the config file in 8c98b4e It is in |
Fix #9