Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed padding strategy, pad by PSF size first then to next highest product of 2,3,57 #33

Merged
merged 5 commits into from
Apr 10, 2019

Conversation

VolkerH
Copy link
Owner

@VolkerH VolkerH commented Apr 10, 2019

With this branch I changed the padding strategy to address GPU memory wastage and wrap-around artefacts.

For background see the dicussions here:
#31

New padding approach:

  • width of the support of the PSF is calculated for each wavelength and the maximum along each spatial dimension is taken as the minimum padding value for that dimension (passed to flowdec as pad_min)
  • the resulting shape is padded to the next product of factors 2,3,5,7 along each dimension. This is done via changes introduced to flowdec in this branch https://github.com/VolkerH/flowdec/tree/padcufft which are not present in the upstream flowdec repo (pull request pending)

@VolkerH VolkerH merged commit 351fe22 into master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant