Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollToTime option for BigCalendar #140

Merged
merged 7 commits into from
Oct 29, 2023
Merged

Conversation

asimonok
Copy link
Collaborator

Resolves #138

Added scrollToTime panel option to scroll day on the selected time. User can scroll up the selected time to see day time slots before.

Screenshot 2023-10-25 at 11 37 57

@asimonok asimonok self-assigned this Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e2c8512) 96.36% compared to head (67c00e3) 96.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   96.36%   96.50%   +0.14%     
==========================================
  Files          56       61       +5     
  Lines         715      744      +29     
  Branches      113      114       +1     
==========================================
+ Hits          689      718      +29     
  Misses         12       12              
  Partials       14       14              
Files Coverage Δ
src/components/BigCalendar/BigCalendar.tsx 91.37% <100.00%> (+0.99%) ⬆️
src/components/BigToolbar/BigToolbar.styles.ts 100.00% <ø> (ø)
src/components/BigToolbar/BigToolbar.tsx 100.00% <100.00%> (ø)
...components/DefaultViewEditor/DefaultViewEditor.tsx 100.00% <100.00%> (ø)
src/components/EventDetails/EventDetails.styles.ts 100.00% <100.00%> (ø)
src/components/EventDetails/EventDetails.tsx 90.90% <100.00%> (ø)
...components/LegacyCalendar/LegacyCalendar.styles.ts 100.00% <100.00%> (ø)
src/components/LegacyCalendar/LegacyCalendar.tsx 97.67% <100.00%> (ø)
...nts/LegacyCalendarEntry/LegacyEventEntry.styles.ts 100.00% <100.00%> (ø)
src/components/LegacyDay/LegacyDay.styles.ts 100.00% <100.00%> (ø)
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature request label Oct 29, 2023
@mikhail-vl mikhail-vl added this to the Version 2.3.0 milestone Oct 29, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit eeda208 into main Oct 29, 2023
5 of 6 checks passed
@mikhail-vl mikhail-vl deleted the feat/hide-empty-slots branch October 29, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide one or more blank time slots with no events
2 participants