Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import order for default big-calendar styles and their overrides #143

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Nov 6, 2023

Resolves #142

@asimonok asimonok self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (43c28da) 96.54% compared to head (577e887) 96.42%.

❗ Current head 577e887 differs from pull request most recent head 7aa2bd7. Consider uploading reports for the commit 7aa2bd7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   96.54%   96.42%   -0.12%     
==========================================
  Files          61       61              
  Lines         752      755       +3     
  Branches      114      114              
==========================================
+ Hits          726      728       +2     
- Misses         12       13       +1     
  Partials       14       14              
Files Coverage Δ
src/components/BigCalendar/BigCalendar.tsx 91.52% <100.00%> (ø)
src/components/BigCalendar/BigCalendar.styles.ts 83.33% <66.66%> (-16.67%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature request label Nov 7, 2023
@mikhail-vl mikhail-vl added this to the Version 2.3.0 milestone Nov 7, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 5613276 into main Nov 7, 2023
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/fix-styles-override branch November 7, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible race condition in Theme loading
2 participants