Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests with testing-library/react #40

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Jun 1, 2023

Increase Test Coverage and move to testing-library/react.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.99 🎉

Comparison is base (f46d145) 42.29% compared to head (1efa63f) 43.29%.

❗ Current head 1efa63f differs from pull request most recent head 5b031c7. Consider uploading reports for the commit 5b031c7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   42.29%   43.29%   +0.99%     
==========================================
  Files          21       22       +1     
  Lines         227      231       +4     
  Branches       26       26              
==========================================
+ Hits           96      100       +4     
  Misses        123      123              
  Partials        8        8              
Impacted Files Coverage Δ
src/components/FieldsEditor/FieldsEditor.tsx 31.57% <50.00%> (ø)
src/components/QueryEditor/QueryEditor.tsx 45.83% <50.00%> (+2.35%) ⬆️
src/components/ValuesEditor/ValuesEditor.tsx 33.33% <50.00%> (+1.75%) ⬆️
src/components/ValueInput/ValueInput.tsx 31.70% <100.00%> (ø)
src/constants/index.ts 100.00% <100.00%> (ø)
src/constants/tests.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@asimonok asimonok requested a review from mikhail-vl June 1, 2023 09:49
@mikhail-vl mikhail-vl added the enhancement New feature or request label Jun 2, 2023
@mikhail-vl mikhail-vl added this to the Version 3.0.0 milestone Jun 2, 2023
@mikhail-vl mikhail-vl changed the title Rewrite tests with testing-library/react Update tests with testing-library/react Jun 2, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit c8b0d4c into main Jun 2, 2023
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-unit-tests branch June 2, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants