Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selection Behavior using Ctrl key #160

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented May 10, 2024

Resolves: #150
Updated selection behavior while all option is active:
Click on item - select the item and deselect others
Click on item with keyboard button (cmd for mac, ctrl for windows and linux) - deselect the item and select others

@vitPinchuk vitPinchuk self-assigned this May 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (8e470a2) to head (2bc4c12).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   98.48%   98.51%   +0.02%     
==========================================
  Files          59       60       +1     
  Lines        1255     1279      +24     
  Branches      361      327      -34     
==========================================
+ Hits         1236     1260      +24     
- Misses         18       19       +1     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label May 27, 2024
@mikhail-vl mikhail-vl added this to the Version 3.1.0 milestone May 27, 2024
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl changed the title Update Selection Behavior Update Selection Behavior using Ctrl key Jun 4, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 5b82459 into main Jun 4, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/clear-selection branch June 4, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection Behavior & Clear Selection Feature
4 participants