Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selection for variables with key/value pair #165

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #163

@vitPinchuk vitPinchuk self-assigned this Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (e104d28) to head (97992b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          60       60           
  Lines        1300     1300           
  Branches      380      380           
=======================================
  Hits         1283     1283           
  Misses         16       16           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to verify if key: value options work as expected

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jun 5, 2024
@mikhail-vl mikhail-vl added this to the Version 3.1.0 milestone Jun 5, 2024
@vitPinchuk vitPinchuk requested a review from asimonok June 5, 2024 10:38
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 49374c3 into main Jun 6, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/multi-level-selection-updated branch June 6, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Allow multi-level selection' doesn't work when variable has key/value pairs
3 participants