Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear value for multi-choice variable #66

Merged
merged 17 commits into from
Oct 16, 2023
Merged

Clear value for multi-choice variable #66

merged 17 commits into from
Oct 16, 2023

Conversation

asimonok
Copy link
Collaborator

Resolves #65

@asimonok asimonok self-assigned this Sep 26, 2023
@asimonok asimonok changed the title Feat/clear option Clear value for multi-choice variable Sep 26, 2023
@mikhail-vl mikhail-vl added the enhancement New feature or request label Sep 27, 2023
@mikhail-vl mikhail-vl added this to the Version 1.8.0 milestone Sep 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (306bfe7) 98.86% compared to head (d805ad7) 98.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   98.86%   98.87%   +0.01%     
==========================================
  Files          50       50              
  Lines         790      803      +13     
  Branches      162      164       +2     
==========================================
+ Hits          781      794      +13     
  Misses          1        1              
  Partials        8        8              
Files Coverage Δ
src/components/MinimizeView/MinimizeView.tsx 100.00% <100.00%> (ø)
src/components/OptionsVariable/OptionsVariable.tsx 100.00% <100.00%> (ø)
src/constants/panel.ts 100.00% <100.00%> (ø)
src/constants/variable.ts 100.00% <100.00%> (ø)
src/module.ts 100.00% <100.00%> (ø)
src/types/panel.ts 100.00% <ø> (ø)
src/utils/variable.ts 98.36% <100.00%> (+0.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 205b48b into main Oct 16, 2023
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/clear-option branch October 16, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't unselect everything in multichoice variable
3 participants