Performance pass #2 (Collection.toArray() call style)

Took 8 minutes
VolmitSoftware · Sep 12, 2020 · 9a7ab90 · 9a7ab90
1 parent 88054ad
commit 9a7ab90
Show file tree

Hide file tree

Showing 25 changed files with 31 additions and 31 deletions.
diff --git a/src/main/java/com/volmit/react/api/Action.java b/src/main/java/com/volmit/react/api/Action.java
@@ -75,7 +75,7 @@ public ISelector[] biselect(ISelector... selectors)
 			set.add(getDefaultSelectors().get(i).get());
 		}
 
-		return set.toArray(new ISelector[set.size()]);
+		return set.toArray(new ISelector[0]);
 	}
 
 	@Override

diff --git a/src/main/java/com/volmit/react/command/CommandAct.java b/src/main/java/com/volmit/react/command/CommandAct.java
@@ -107,7 +107,7 @@ public void fire(CommandSender sender, String[] args)
 		{
 			force = true;
 			ar.remove(ar.last());
-			args = ar.toArray(new String[ar.size()]);
+			args = ar.toArray(new String[0]);
 		}
 
 		if(args.length == 1)

diff --git a/src/main/java/com/volmit/react/command/CommandFix.java b/src/main/java/com/volmit/react/command/CommandFix.java
@@ -74,6 +74,6 @@ public void fire(CommandSender sender, String[] args)
 		String name = args[0];
 		GList<String> argx = new GList<String>(args);
 		argx.remove(0);
-		React.instance.fixController.runFix(sender, name, argx.toArray(new String[argx.size()]));
+		React.instance.fixController.runFix(sender, name, argx.toArray(new String[0]));
 	}
 }
diff --git a/src/main/java/com/volmit/react/controller/ActionController.java b/src/main/java/com/volmit/react/controller/ActionController.java
@@ -317,7 +317,7 @@ public void tick()
 			GTriset<ActionType, IActionSource, GList<ISelector>> i = pending.get(d);
 			IAction action = getAction(i.getA());
 			IActionSource source = i.getB();
-			ISelector[] selectors = i.getC().toArray(new ISelector[i.getC().size()]);
+			ISelector[] selectors = i.getC().toArray(new ISelector[0]);
 			boolean running = action.getState().equals(ActionState.IDLE);
 
 			try

diff --git a/src/main/java/com/volmit/react/controller/CommandController.java b/src/main/java/com/volmit/react/controller/CommandController.java
@@ -365,7 +365,7 @@ else if(a.length > 0)
 					acts.add("a");
 					acts.addAll(new GList<String>(a));
 
-					onCommand(plr ? px : s, c, n, acts.toArray(new String[acts.size()])); // $NON-NLS-1$
+					onCommand(plr ? px : s, c, n, acts.toArray(new String[0])); // $NON-NLS-1$
 				}
 
 				else

diff --git a/src/main/java/com/volmit/react/controller/GraphController.java b/src/main/java/com/volmit/react/controller/GraphController.java
@@ -297,7 +297,7 @@ public void toggleMapping(Player player, String[] args)
 				r.add(rp.pargs);
 			}
 
-			toggleMapping(player, r.toArray(new String[r.size()]));
+			toggleMapping(player, r.toArray(new String[0]));
 			return;
 		}
 

diff --git a/src/main/java/com/volmit/react/util/Area.java b/src/main/java/com/volmit/react/util/Area.java
@@ -139,7 +139,7 @@ public Entity[] getNearbyEntities(EntityType type)
 			}
 		}
 
-		return e.toArray(new Entity[e.size()]);
+		return e.toArray(new Entity[0]);
 	}
 
 	/**
@@ -161,7 +161,7 @@ public Entity[] getNearbyEntities(Class<? extends Entity> entityClass)
 			}
 		}
 
-		return e.toArray(new Entity[e.size()]);
+		return e.toArray(new Entity[0]);
 	}
 
 	/**
@@ -198,7 +198,7 @@ public Entity[] getNearbyEntities()
 				}
 			}
 
-			return radiusEntities.toArray(new Entity[radiusEntities.size()]);
+			return radiusEntities.toArray(new Entity[0]);
 		}
 
 		catch(Throwable e)
@@ -225,7 +225,7 @@ public Player[] getNearbyPlayers()
 			}
 		}
 
-		return px.toArray(new Player[px.size()]);
+		return px.toArray(new Player[0]);
 	}
 
 	/**

diff --git a/src/main/java/com/volmit/react/util/ParallelPoolManager.java b/src/main/java/com/volmit/react/util/ParallelPoolManager.java
@@ -293,7 +293,7 @@ public int getQueueSize()
 
 	public ParallelThread[] getThreads()
 	{
-		return threads.toArray(new ParallelThread[threads.size()]);
+		return threads.toArray(new ParallelThread[0]);
 	}
 
 	private void updateThreadInformation()

diff --git a/src/main/java/com/volmit/react/xrai/VirtualAction.java b/src/main/java/com/volmit/react/xrai/VirtualAction.java
@@ -97,7 +97,7 @@ public void execute()
 			}
 		}
 
-		React.instance.actionController.fire(getActionType(), new RAIActionSource(), selectors.toArray(new ISelector[selectors.size()]));
+		React.instance.actionController.fire(getActionType(), new RAIActionSource(), selectors.toArray(new ISelector[0]));
 	}
 
 	public JSONObject toJSON()

diff --git a/src/main/java/primal/bukkit/command/VirtualCommand.java b/src/main/java/primal/bukkit/command/VirtualCommand.java
@@ -109,7 +109,7 @@ public boolean hit(CommandSender sender, GList<String> chain)
 			return true;
 		}
 
-		return command.handle(vs, chain.toArray(new String[chain.size()]));
+		return command.handle(vs, chain.toArray(new String[0]));
 	}
 
 	private boolean checkPermissions(CommandSender sender, ICommand command2)

diff --git a/src/main/java/primal/bukkit/nms/Catalyst10.java b/src/main/java/primal/bukkit/nms/Catalyst10.java
@@ -791,7 +791,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst11.java b/src/main/java/primal/bukkit/nms/Catalyst11.java
@@ -790,7 +790,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst12.java b/src/main/java/primal/bukkit/nms/Catalyst12.java
@@ -790,7 +790,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst13_R2.java b/src/main/java/primal/bukkit/nms/Catalyst13_R2.java
@@ -815,7 +815,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst14.java b/src/main/java/primal/bukkit/nms/Catalyst14.java
@@ -771,7 +771,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst15.java b/src/main/java/primal/bukkit/nms/Catalyst15.java
@@ -771,7 +771,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst16.java b/src/main/java/primal/bukkit/nms/Catalyst16.java
@@ -796,7 +796,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst16_R2.java b/src/main/java/primal/bukkit/nms/Catalyst16_R2.java
@@ -796,7 +796,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
     @Override
     public void sendEntityMetadata(Player p, int eid, List<Object> objects)
     {
-        sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+        sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
     }
 
     @Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst8.java b/src/main/java/primal/bukkit/nms/Catalyst8.java
@@ -772,7 +772,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/Catalyst94.java b/src/main/java/primal/bukkit/nms/Catalyst94.java
@@ -791,7 +791,7 @@ public void sendEntityMetadata(Player p, int eid, Object... objects)
 	@Override
 	public void sendEntityMetadata(Player p, int eid, List<Object> objects)
 	{
-		sendEntityMetadata(p, eid, objects.toArray(new Object[objects.size()]));
+		sendEntityMetadata(p, eid, objects.toArray(new Object[0]));
 	}
 
 	@Override

diff --git a/src/main/java/primal/bukkit/nms/V.java b/src/main/java/primal/bukkit/nms/V.java
@@ -98,7 +98,7 @@ public Object invoke(String method, Object... parameters)
 
 		try
 		{
-			return (local ? Violator.getDeclaredMethod(o.getClass(), method, par.toArray(new Class<?>[par.size()])) : Violator.getMethod(o.getClass(), method, par.toArray(new Class<?>[par.size()]))).invoke(o, parameters);
+			return (local ? Violator.getDeclaredMethod(o.getClass(), method, par.toArray(new Class<?>[0])) : Violator.getMethod(o.getClass(), method, par.toArray(new Class<?>[0]))).invoke(o, parameters);
 		}
 
 		catch(Throwable e)

diff --git a/src/main/java/primal/bukkit/nms/Violator.java b/src/main/java/primal/bukkit/nms/Violator.java
@@ -163,7 +163,7 @@ public static <T> T construct(Class<?> c, Object... parameters)
 
 		try
 		{
-			Constructor<?> co = getConstructor(c, cv.toArray(new Class<?>[cv.size()]));
+			Constructor<?> co = getConstructor(c, cv.toArray(new Class<?>[0]));
 			return (T) co.newInstance(parameters);
 		}
 

diff --git a/src/main/java/primal/bukkit/world/Area.java b/src/main/java/primal/bukkit/world/Area.java
@@ -139,7 +139,7 @@ public Entity[] getNearbyEntities(EntityType type)
 			}
 		}
 
-		return e.toArray(new Entity[e.size()]);
+		return e.toArray(new Entity[0]);
 	}
 
 	/**
@@ -161,7 +161,7 @@ public Entity[] getNearbyEntities(Class<? extends Entity> entityClass)
 			}
 		}
 
-		return e.toArray(new Entity[e.size()]);
+		return e.toArray(new Entity[0]);
 	}
 
 	/**
@@ -193,7 +193,7 @@ public Entity[] getNearbyEntities()
 				}
 			}
 
-			return radiusEntities.toArray(new Entity[radiusEntities.size()]);
+			return radiusEntities.toArray(new Entity[0]);
 		}
 
 		catch(Exception e)
@@ -219,7 +219,7 @@ public Player[] getNearbyPlayers()
 			}
 		}
 
-		return px.toArray(new Player[px.size()]);
+		return px.toArray(new Player[0]);
 	}
 
 	/**

diff --git a/src/main/java/primal/util/reflection/V.java b/src/main/java/primal/util/reflection/V.java
@@ -119,7 +119,7 @@ public Object invoke(String method, Object... parameters)
 
 		try
 		{
-			return (local ? Violator.getDeclaredMethod(o.getClass(), method, par.toArray(new Class<?>[par.size()])) : Violator.getMethod(o.getClass(), method, par.toArray(new Class<?>[par.size()]))).invoke(o, parameters);
+			return (local ? Violator.getDeclaredMethod(o.getClass(), method, par.toArray(new Class<?>[0])) : Violator.getMethod(o.getClass(), method, par.toArray(new Class<?>[0]))).invoke(o, parameters);
 		}
 
 		catch(Throwable e)

diff --git a/src/main/java/primal/util/reflection/Violator.java b/src/main/java/primal/util/reflection/Violator.java
@@ -163,7 +163,7 @@ public static <T> T construct(Class<?> c, Object... parameters)
 
 		try
 		{
-			Constructor<?> co = getConstructor(c, cv.toArray(new Class<?>[cv.size()]));
+			Constructor<?> co = getConstructor(c, cv.toArray(new Class<?>[0]));
 			return (T) co.newInstance(parameters);
 		}