Support for i.MX 8M chipsets #8
Conversation
|
Gentle ping. Thanks, |
|
This looks really great, I appreciate the contribution. I'll give a quick manual test on our end and assuming it all works I'll be happy to merge it. |
|
@passgat could you provide:
I realized I am missing the same for am33 and mp157 but I intend to add that... I have it here somewhere... |
i2c_eeprom.c:88:45: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘ssize_t’ {aka ‘long int’} [-Wformat=]
88 | fprintf(stderr, "Incomplete write: %d bytes!\n", written);
| ~^ ~~~~~~~
| | |
| int ssize_t {aka long int}
| %ld
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
|
@thom-nic |
|
A gentle ping. Thanks, |
|
@passgat thanks for the reminder. I will try to fit this in soon. Your contribution looks great of course. I don't have much in the way of feedback w/r/t the i.MX 8 code specifically since I don't have that hardware. I mostly need to build your branch and regression test it for our hw platforms that we use. |
|
I added the imx8m platform because I needed the bootcounnt support for it. So I run tests on this platform. I run tests on the beaglebome (am33xx) and the stm32mp157f-dk2 too, so I don't expect regressions. I don't remember If I run test on eeprom, but I don't think so. Thanks, |
|
That's fine, thank you. I'll do some quick testing on my end so I can merge the PR |
Following the software principle 'Don't repeat yourself,' the patch groups the source code for register access, where reading/writing the bootcount value, into a single function with parameters to make it usable across different architectures. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Born as a project to read/write the bootcount on the TI am3xx platform, over time it has introduced bootcount management on EEPROM and for the stm32mp1 platform. As a result, the project removed the 'davinci' tag from its name and GitHub link. The patch fixes references to the old project name that are still present in some project files. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
In case of failure for all supported platforms this was the error message: No DT node /proc/device-tree/compatible No DT node /proc/device-tree/compatible No DT node /proc/device-tree/compatible Now with: No DT node /proc/device-tree/compatible while searching for "ti,am33xx" No DT node /proc/device-tree/compatible while searching for "st,stm32mp153" No DT node /proc/device-tree/compatible while searching for "st,stm32mp157" the reported info is more meaningful. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
This is a preparatory patch for future developments that will increase the number of platforms on which the bootcount application can operate. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
By doing this, the function can be called by platform modules as well as by the EEPROM module. This is a preparatory patch for future developments that will expand the number of platforms on which the bootcount application can operate. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
The patch finalizes the separation between the generic bootcount code and platform-specific code. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
The patch hides data that should not be exported in the corresponding .c file. This prevents them from being improperly used outside of the module. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Make the function name consistent with the module name. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
In U-Boot, with the CONFIG_SYS_BOOTCOUNT_{BE,LE} configurations, it is
possible to define the endianness of the bootcount value. The patch adds
support for this option while ensuring backward compatibility.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
The patch adds support for endianness on the TI am33xx platform. As highlighted by the output of the following command, some am33xx boards use big-endian access for the bootcount value, while others adopt little-endian access (default). The BeagleBone Black, on which I run the tests, accesses it in big-endian mode. cd <U-Boot_dir> git grep CONFIG_SYS_BOOTCOUNT_ | grep am335x configs/am335x_boneblack_vboot_defconfig:CONFIG_SYS_BOOTCOUNT_BE=y configs/am335x_evm_defconfig:CONFIG_SYS_BOOTCOUNT_BE=y configs/am335x_evm_spiboot_defconfig:CONFIG_SYS_BOOTCOUNT_BE=y configs/am335x_hs_evm_defconfig:CONFIG_SYS_BOOTCOUNT_BE=y configs/am335x_hs_evm_uart_defconfig:CONFIG_SYS_BOOTCOUNT_BE=y configs/am335x_sl50_defconfig:CONFIG_SYS_BOOTCOUNT_BE=y Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Adds bootcount support for the IMX8M platform. Thanks to the previous commits, the added code is primarily located in the new platform modules. Few are the changes in the bootcount.c file. The bootcount address has been taken directly from the U-Boot configurations: cd <U-Boot_dir> git grep BOOTCOUNT_ADDR configs/ | grep imx8m configs/imx8mm-mx8menlo_defconfig:CONFIG_SYS_BOOTCOUNT_ADDR=0x30370090 configs/imx8mm_data_modul_edm_sbc_defconfig:CONFIG_SYS_BOOTCOUNT_ADDR=0x30370090 configs/imx8mp_data_modul_edm_sbc_defconfig:CONFIG_SYS_BOOTCOUNT_ADDR=0x30370090 configs/imx8mp_dhcom_pdk2_defconfig:CONFIG_SYS_BOOTCOUNT_ADDR=0x30370090 configs/imx8mp_dhcom_pdk3_defconfig:CONFIG_SYS_BOOTCOUNT_ADDR=0x30370090 Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
|
Done, |
|
Finally got to testing this on an EEPROM device. Looks great. Thanks for the contribution! |
|
@thom-nic Thank you for having merged the PR. Is it possible to add a tag to release a new version so that I can then update the package in Buildroot? Thanks and regards |
|
@passgat I will do a release. I also really should update the README for IMX8 and STM32MP1 as well.. |
|
@thom-nic Many thanks! |
The series adds bootcount support for the i.MX8M platform (last patch).
It also includes rework patches to facilitate the addition of a new platform and two patches to handle the
endianness of the bootcount value.
I have tested the series on the STM32MP1, am33xx (BeagleBone), and i.MX8M platforms.