feat(empty-state): adding connotation and design variation (VIV-1378) #1863
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 342 +219
Lines 1562 6217 +4655
Branches 108 781 +673
===========================================
+ Hits 1562 6217 +4655
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @include connotation.connotation(badge); | ||
| @include appearance.appearance; |
There was a problem hiding this comment.
IMO, it is not right to use appearance mixin here. Design didn't use appearance so why should the code? The mixed colors end up different from the design
| @include connotation.connotation(badge); | |
| @include appearance.appearance; | |
| @include connotation.connotation(empty-state); |
There was a problem hiding this comment.
the badge is a huge mistake of mine and I'll fix it.
But we are always using connotation and appearance together - see alert & progress.
On the other hand we have icons that do not use it.
I wonder what is the right way to do that.
Do we want all components that has one appearance, no states to use connotation directly or use it via appearances...
If I'm not using connotation directly - I can use whatever shades I want, is it good for the design-system or should we align to appearances?
@AyalaBu @TaylorJ76
WDYT?
There was a problem hiding this comment.
I removed the appearance and created a ticket to align other component to the same convention: https://jira.vonage.com/browse/VIV-1960
Co-authored-by: Richard Helm <86777660+RichardHelm@users.noreply.github.com>
No description provided.