Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(elevation): no default dom mutation #268

Merged
merged 15 commits into from
Mar 28, 2022
Merged

refactor(elevation): no default dom mutation #268

merged 15 commits into from
Mar 28, 2022

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Mar 24, 2022

No description provided.

@yinonov yinonov mentioned this pull request Mar 24, 2022
Merged
@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited

Codecov Report

Merging #268 (8bbd973) into main (058e9d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          40       40           
  Lines         424      424           
  Branches        5        5           
=======================================
  Hits          408      408           
  Misses         14       14           
  Partials        2        2
Flag Coverage Δ
unittests 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/components/src/lib/elevation/elevation.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 058e9d5...8bbd973. Read the comment docs.

@rinaok rinaok marked this pull request as draft March 24, 2022 14:12
@rinaok rinaok marked this pull request as ready for review March 24, 2022 14:13
@yinonov yinonov marked this pull request as draft March 25, 2022 16:34
@yinonov yinonov marked this pull request as ready for review March 25, 2022 16:34
@yinonov yinonov changed the title refactor(elevation): no default dom mutation refactor(elevation): no default dom mutation Mar 25, 2022
@yinonov yinonov changed the title refactor(elevation): no default dom mutation refactor(elevation): no default dom mutation Mar 25, 2022
@yinonov yinonov added the Type: Style ⭐ changes that do not affect the meaning of the code label Mar 25, 2022
@yinonov yinonov merged commit 6d5ec3f into main Mar 28, 2022
@yinonov yinonov deleted the elevation-no-default-dom-mutation branch March 28, 2022 10:44
@rachelbt rachelbt mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelbt rachelbt rachelbt left review comments

@rinaok rinaok rinaok left review comments

Assignees
No one assigned
Labels
Type: Style ⭐ changes that do not affect the meaning of the code
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yinonov @rachelbt @rinaok