This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Respect members/events/attributes inherited from superclass #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #7
We were previously generating the vue component props from the vivid component's fields, instead of the vivid component's attributes. This led to a few quirks, e.g.
VwcCard
declaredgraphicSlottedContent
andhasMetaSlottedContent
props which don't correspond to any vvd3-card attributes (and I don't think are intended to be set by vivid consumers). This led to more obvious problems when inheriting members from superclasses, as some fields defined in superclasses were clearly not meant to be set via attributes - so this PR switches the generator to use attributes instead, which should be more "correct".This also changes the generated vue files to set vivid component attributes as kebab-case (
<vvd3-button :icon-trailing="iconTrailing">
) instead of camelCase (<vvd3-button :iconTrailing="iconTrailing">
) - this is largely insignificant, but now conforms to the vue recommended practice "the convention is using kebab-case in all cases to align with HTML attributes"VwcButton.vue
Before:And after: