Skip to content

Commit

Permalink
feat(vwc-icon): removed "size" from observed attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
Tal Weinfeld committed Sep 29, 2020
1 parent f4c375a commit 2b44f0f
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions components/icon/src/vwc-icon.js
Expand Up @@ -81,7 +81,7 @@ class IconElement extends HTMLElement {
}

static get observedAttributes() {
return ["type", "size"];
return ["type"];
}

set type(value) {
Expand All @@ -97,11 +97,7 @@ class IconElement extends HTMLElement {
}

set size(value) {
if (!Object.keys(SIZES).includes(value)) {
console.warn(`Size can either be "${Object.keys(SIZES).join(',')}"`);
} else {
this.setAttribute('size', value);
}
this.setAttribute('size', value);
}

get size() {
Expand Down

0 comments on commit 2b44f0f

Please sign in to comment.