Skip to content

Commit

Permalink
fix(layout): correct connotation refs (#1194)
Browse files Browse the repository at this point in the history
* fix(layout): correct connotation refs

* correct refs

* update affected snapshots

* redundant connotation test. handled by ui-test
  • Loading branch information
yinonov committed Jan 24, 2022
1 parent 4ad0458 commit a5c9d30
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 78 deletions.
5 changes: 3 additions & 2 deletions common/foundation/scss/mixins/layout/_mixins.scss
Expand Up @@ -23,10 +23,11 @@ $all-layouts: (

%outlined {
#{variables.$vvd-layout-color-fill}: transparent;
#{variables.$vvd-layout-color-outline}: var(#{connotation.$vvd-color-connotation});
@if (config.$outline-duotone) {
#{variables.$vvd-layout-color-outline}: var(#{connotation.$vvd-color-connotation});
#{variables.$vvd-layout-color-text}: var(#{connotation.$vvd-color-connotation}-contrast);
} @else {
#{variables.$vvd-layout-color-outline}: var(#{connotation.$vvd-color-connotation}-diverse);
#{variables.$vvd-layout-color-text}: var(#{connotation.$vvd-color-connotation}-diverse);
}
}
Expand All @@ -39,7 +40,7 @@ $all-layouts: (
%text,
%ghost {
#{variables.$vvd-layout-color-fill}: transparent;
#{variables.$vvd-layout-color-text}: var(#{connotation.$vvd-color-connotation});
#{variables.$vvd-layout-color-text}: var(#{connotation.$vvd-color-connotation}-diverse);
}

@function get-typed-selector($type) {
Expand Down
76 changes: 0 additions & 76 deletions components/button/test/button.connotation.test.js

This file was deleted.

Binary file modified ui-tests/snapshots/vwc-button.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/snapshots/vwc-icon-button-toggle.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/snapshots/vwc-icon-button.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit a5c9d30

Please sign in to comment.