Skip to content

Commit

Permalink
feat(vwc-popup): change anchorEl to anchorId (#1214)
Browse files Browse the repository at this point in the history
* change anchor to id

* Update components/popup/src/vwc-popup-base.ts

Co-authored-by: yinon <yinon@hotmail.com>

* set anchorEl as getter

* remove first updated

* refactor code

* update tests

* update tests

* update ui test

* remove change event

* add anchor tests

* Update components/popup/test/popup.test.js

Co-authored-by: Yonatan Kra <yonatan.kra@vonage.com>

* Update components/popup/test/popup.test.js

Co-authored-by: Yonatan Kra <yonatan.kra@vonage.com>

* add comment to test

* update getAnchorById

* add anchorEl property

* add IntersectionObserver

* add TODO

* delete ui test

Co-authored-by: yinon <yinon@hotmail.com>
Co-authored-by: Yonatan Kra <yonatan.kra@vonage.com>
  • Loading branch information
3 people committed Feb 7, 2022
1 parent f8896e9 commit c7640bd
Show file tree
Hide file tree
Showing 5 changed files with 281 additions and 262 deletions.

0 comments on commit c7640bd

Please sign in to comment.