Skip to content

Commit

Permalink
fix(checkbox & radiobutton): border-color change (#1187)
Browse files Browse the repository at this point in the history
Co-authored-by: yinon <yinon@hotmail.com>
  • Loading branch information
rachelbt and yinonov committed Jan 6, 2022
1 parent 7053f79 commit f02fd7d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions components/checkbox/src/vwc-checkbox.scss
Expand Up @@ -3,7 +3,7 @@
:host {
--mdc-checkbox-ink-color: var(#{scheme-variables.$vvd-color-neutral-10});
--mdc-checkbox-checked-color: var(#{scheme-variables.$vvd-color-on-canvas});
--mdc-checkbox-unchecked-color: var(#{scheme-variables.$vvd-color-on-canvas});
--mdc-checkbox-unchecked-color: var(#{scheme-variables.$vvd-color-neutral-70});
--mdc-checkbox-disabled-color: var(
#{scheme-variables.$vvd-color-neutral-30}
);
Expand Down Expand Up @@ -54,8 +54,9 @@
.mdc-checkbox__native-control:enabled {
&:hover,
&:focus {

~ .mdc-checkbox__background {
box-shadow: 0 0 3px rgba(0, 0, 0, 0.5);
--mdc-checkbox-unchecked-color: var(#{scheme-variables.$vvd-color-on-canvas});
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions components/radio/src/vwc-radio.scss
@@ -1,7 +1,7 @@
@use '@vonage/vvd-design-tokens/build/scss/semantic-variables/_scheme-variables' as scheme-variables;

:host {
--mdc-radio-unchecked-color: var(#{scheme-variables.$vvd-color-on-canvas});
--mdc-radio-unchecked-color: var(#{scheme-variables.$vvd-color-neutral-70});
--mdc-radio-disabled-color: var(#{scheme-variables.$vvd-color-neutral-30});
}

Expand All @@ -21,8 +21,8 @@
.mdc-radio__native-control:enabled {
&:hover,
&:focus {
+ .mdc-radio__background .mdc-radio__outer-circle {
box-shadow: 0 0 3px rgba(0, 0, 0, 0.5);
~ .mdc-radio__background .mdc-radio__outer-circle {
--mdc-radio-unchecked-color: var(#{scheme-variables.$vvd-color-on-canvas});
}
}
}
Expand Down
Binary file modified ui-tests/snapshots/vwc-data-grid.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/snapshots/vwc-list.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit f02fd7d

Please sign in to comment.