Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar - Choosing time format #1078

Closed
avivVonage opened this issue Oct 4, 2021 · 1 comment
Closed

Calendar - Choosing time format #1078

avivVonage opened this issue Oct 4, 2021 · 1 comment
Assignees
@yinonov
Labels
Component: Calendar good first issue Good for newcomers

Comments

@avivVonage
Copy link

avivVonage commented Oct 4, 2021 •
edited

Is your feature request related to a problem? Please describe.
The time format that the calendar component uses is always 12H, but in some countries the time format is 24H e.g. 13:00 instead of 1:00PM.

Describe the solution you'd like
We would like to be able to choose the time format in the calendar component.

Additional context
This is needed for the VR Scheduling project Q4 tasks.

Screen Shot 2021-10-04 at 15 41 21
@yinonov yinonov self-assigned this Oct 4, 2021
yinonov added a commit that referenced this issue Oct 22, 2021
@yinonov
Calendar - Choosing time format
1d139a3 
Fixes #1078
@yinonov yinonov closed this as completed Oct 22, 2021
@yinonov
Copy link
Contributor

yinonov commented Oct 22, 2021

Fixed by #1103

yinonov added a commit that referenced this issue Oct 23, 2021
@yinonov
fix(calendar): harden test (#1105)
e3c4778 
* feat(calendar): support time format hour12

* Calendar - Choosing time format
Fixes #1078

* api test as snapshots

* deterministic test

* battle tested

* Update ui-tests/tests/vwc-calendar/index.js

* comment out locales unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yinonov yinonov

Labels
Component: Calendar good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yinonov @avivVonage