Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(card): redefine interface #1131

Merged
merged 22 commits into from Apr 4, 2022
Merged

feat(card): redefine interface #1131

merged 22 commits into from Apr 4, 2022

Conversation

rachelbt
Copy link
Contributor

image

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

YonatanKra
YonatanKra requested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the card can also get out of Alpha phase. What do you think @yinonov ?

yinonov
yinonov suggested changes Nov 22, 2021
View reviewed changes
components/card/readme.md Outdated Show resolved Hide resolved
components/card/src/vwc-card.scss Outdated Show resolved Hide resolved
yinonov
yinonov suggested changes Dec 14, 2021
View reviewed changes
components/card/readme.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rachelbt rachelbt self-assigned this Dec 30, 2021
@yinonov yinonov linked an issue Mar 9, 2022 that may be closed by this pull request
[card] redefine interface #1255
Closed
@rachelbt rachelbt changed the title feat(card): top action slot feat(card): redefine interface Mar 21, 2022
yinonov
yinonov suggested changes Mar 22, 2022
View reviewed changes
components/card/src/vwc-card.ts Outdated Show resolved Hide resolved
components/card/src/vwc-card.ts Outdated Show resolved Hide resolved
components/card/src/vwc-card.ts Show resolved Hide resolved
components/card/src/vwc-card.ts Show resolved Hide resolved
components/card/src/vwc-card.ts Show resolved Hide resolved
components/card/src/vwc-card.ts Show resolved Hide resolved
@rachelbt rachelbt requested a review from yinonov March 27, 2022 07:15
@yinonov
Copy link
Contributor

yinonov commented Mar 27, 2022

I think the card can also get out of Alpha phase. What do you think @yinonov ?

once we merge it now yes. @rachelbt move in story?

@rachelbt
Copy link
Contributor Author

rachelbt commented Mar 27, 2022 •
edited

I think the card can also get out of Alpha phase. What do you think @yinonov ?

once we merge it now yes. @rachelbt move in story?

@yinonov @YonatanKra - don't we want to wait until we will integrate the elevation?

yinonov
yinonov suggested changes Mar 27, 2022
View reviewed changes
components/card/src/vwc-card.ts Outdated Show resolved Hide resolved
components/card/src/vwc-card.ts Outdated Show resolved Hide resolved
components/card/src/vwc-card.ts Outdated Show resolved Hide resolved
@rachelbt rachelbt requested a review from yinonov March 27, 2022 13:04
yinonov
yinonov previously approved these changes Mar 28, 2022
View reviewed changes
yinonov
yinonov previously approved these changes Apr 4, 2022
View reviewed changes
YonatanKra
YonatanKra approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rachelbt rachelbt merged commit ec49b38 into master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YonatanKra YonatanKra YonatanKra approved these changes

@yinonov yinonov yinonov left review comments

Assignees

@rachelbt rachelbt

Labels
None yet
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[card] redefine interface
4 participants
@rachelbt @yinonov @YonatanKra @rinaok