Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[card] redefine interface #1255

Closed
yinonov opened this issue Mar 9, 2022 · 10 comments · Fixed by #1131
Closed

[card] redefine interface #1255

yinonov opened this issue Mar 9, 2022 · 10 comments · Fixed by #1131
Assignees

Comments

@yinonov
Copy link
Contributor

yinonov commented Mar 9, 2022

is a visual container without semantics typically used in a group to present collections of related information.
Vivid care about having a single look & feel and introduces an opinionated characteristics to card.
still, there are often cases where authors need to deviate from that authored characteristics. therefore we'd like to introduce a solution for more than 1 type of use.

adopting stacking slots approach to wrap the opinionated layout with slots and enable authors the ability to allow any content in card
image

@yinonov yinonov linked a pull request Mar 9, 2022 that will close this issue
@rachelbt
Copy link
Contributor

rachelbt commented Mar 9, 2022

a long time ago we discussed the slot names in the card and meta was suggested by you for the footer of the card.
The "circle" slot was supposed to be action / top action:
https://docs.google.com/document/d/1FLMPYki_qo0YBvXvAI_DPsM4yBqn_bLSWiDfA0fiwHs/edit

@yinonov
Copy link
Contributor Author

yinonov commented Mar 9, 2022

think of this in comparison to a dialog. what should be the API?

@yinonov
Copy link
Contributor Author

yinonov commented Mar 10, 2022

@jshenkman does card respect all elevation dps? or only answers to a single value?
if so, note that this redefined approach makes elevation API redundant as same UI can be easily achieved by card

@rachelbt
Copy link
Contributor

rachelbt commented Mar 14, 2022

when rethinking about the card areas we should also take in mind its spacing.
When theres more than one card in a row - I guess that we would like the footer/action to be aligned to the bottom like this:
image

and not this (the state currently):
image

@yinonov
Copy link
Contributor Author

yinonov commented Mar 15, 2022

when rethinking about the card areas we should also take in mind its spacing. When theres more than one card in a row - I guess that we would like the footer/action to be aligned to the bottom like this: image

and not this (the state currently): image

right, can occur on grids. good one

@yinonov
Copy link
Contributor Author

yinonov commented Mar 20, 2022

include #1135

@jshenkman
Copy link
Contributor

jshenkman commented Mar 21, 2022

@jshenkman does card respect all elevation dps? or only answers to a single value? if so, note that this redefined approach makes elevation API redundant as same UI can be easily achieved by card

Card needs to have at least a few elevation values, but not necessarily all of them.
Some examples for this would be -

  1. Cards with elevation 0dp so they can have a flat style design with no elevation and only outline
  2. Cards with a default elevation of 8dp
  3. Card with changing elevation to represent hover state, for example, 8dp to 16dp or 0dp to 12dp

If you want some visual examples lmk @rachelbt :)

@jshenkman
Copy link
Contributor

jshenkman commented Mar 21, 2022

Another requirement that was brought up by designers is supporting a few text styles in the title/header.
Currently, we support one style - Subtitle-2. It would be helpful to allow some more text styles specifically body-1-bold and subtitle-1.

A similar implementation can be seen in Spectrum by Adobe

@rachelbt
Copy link
Contributor

Another requirement that was brought up by designers is supporting a few text styles in the title/header. Currently, we support one style - Subtitle-2. It would be helpful to allow some more text styles specifically body-1-bold and subtitle-1.

A similar implementation can be seen in Spectrum by Adobe

@yinonov are we going to support this or we will leave default slot fo the variations?

@yinonov
Copy link
Contributor Author

yinonov commented Mar 22, 2022

Spectrum apply the same practice of slotted content overriding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants