Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] add stacked layout #1156

Closed
jshenkman opened this issue Dec 20, 2021 · 4 comments · Fixed by #1174
Closed

[Button] add stacked layout #1156

jshenkman opened this issue Dec 20, 2021 · 4 comments · Fixed by #1174
Assignees
@rachelbt
Labels
Component: Layout

Comments

@jshenkman
Copy link
Contributor

jshenkman commented Dec 20, 2021 •
edited by yinonov

image
@jshenkman
Copy link
Contributor Author

jshenkman commented Dec 27, 2021 •
edited

You can find the design here

we will want to add support to the following -

trailing & leading icon
rounded & pilled shape

@yinonov
Copy link
Contributor

yinonov commented Dec 27, 2021

Does stack correlate with dense & enlarged or any other button variants?

@jshenkman
Copy link
Contributor Author

jshenkman commented Dec 27, 2021 •
edited

Does stack correlate with dense & enlarged or any other button variants?

Yes, we will have also the 3 sizes.
So same properties for padding and spacing, for shape (border-radius), connotation, and all properties actually except for 'text only' which we don't need

@jshenkman jshenkman assigned rachelbt and unassigned yinonov Dec 27, 2021
@yinonov yinonov pinned this issue Dec 27, 2021
yinonov added a commit that referenced this issue Dec 27, 2021
@yinonov
feat(button): stacked style flow support
f966d52 
add button stacked flow style to meet teams demand

Closes #1156
@yinonov yinonov mentioned this issue Dec 27, 2021
Merged
8 tasks
@rachelbt
Copy link
Contributor

rachelbt commented Dec 29, 2021 •
edited

stacked:
https://tmp.dev.vivid.vonage.com/1174/index.html?path=/story/components-button--stacked

Mixed sizes - you can change them all to pill, connotation and stacked
https://tmp.dev.vivid.vonage.com/1174/index.html?path=/story/components-button--mixes-sizes

@rachelbt rachelbt unpinned this issue Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachelbt rachelbt

Labels
Component: Layout
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(button): stacked style flow support Vonage/vivid
3 participants
@rachelbt @yinonov @jshenkman