Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button): stacked style flow support #1174

Merged
merged 16 commits into from Dec 30, 2021
Merged

feat(button): stacked style flow support #1174

merged 16 commits into from Dec 30, 2021

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Dec 27, 2021

add button stacked flow style to meet teams demand

Closes #1156

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yinonov
feat(button): stacked style flow support
f966d52 
add button stacked flow style to meet teams demand

Closes #1156
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

yinonov
yinonov commented Dec 28, 2021
View reviewed changes
components/button/src/vwc-button.scss Outdated
@@ -117,6 +105,32 @@
:host([enlarged]) & {
--mdc-button-horizontal-padding: 20px;
}

:host([stacked][enlarged]) & {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can leverage the button-stacked class here
with sass

.button-stacked {
    :host([enlarged]) & {

    }
}

@yinonov
Copy link
Contributor Author

yinonov commented Dec 29, 2021 •
edited

Ripple overflows the button region

image

(Happens on my iOS)

@rachelbt
Copy link
Contributor

rachelbt commented Dec 29, 2021 •
edited

Ripple overflows the button region

image

(Happens on my iOS)

it happens also in Safari for all the outlined+pill buttons. I'll check it out. Maybe we should deal with it in a separate issue?

@yinonov
Copy link
Contributor Author

yinonov commented Dec 29, 2021 •
edited

Ripple overflows the button region

image

(Happens on my iOS)

it happens also in Safari for all the outlined+pill buttons. I'll check it out. Maybe we should deal with it in a separate issue?

If it's not related to this new change, of course #1180

@yinonov yinonov mentioned this pull request Dec 29, 2021
Closed
@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit d4d975d into master Dec 30, 2021
@yinonov yinonov linked an issue Jan 16, 2022 that may be closed by this pull request
[button] support stacked #1196
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YonatanKra YonatanKra Awaiting requested review from YonatanKra

Assignees

@rachelbt rachelbt

Labels
None yet
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[button] support stacked [Button] add stacked layout
2 participants
@yinonov @rachelbt