feat(accordion): add meta #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Latest successful build of the PR deployed here. 🚀 |
This was
linked to
issues
Feb 1, 2022
YonatanKra
reviewed
Feb 7, 2022
YonatanKra
reviewed
Feb 7, 2022
YonatanKra
reviewed
Feb 7, 2022
YonatanKra
reviewed
Feb 7, 2022
Co-authored-by: Yonatan Kra <yonatan.kra@vonage.com>
Co-authored-by: Yonatan Kra <yonatan.kra@vonage.com>
Co-authored-by: Yonatan Kra <yonatan.kra@vonage.com>
yinonov
suggested changes
Feb 17, 2022
rachelbt
changed the title
yinonov
reviewed
Feb 20, 2022
yinonov
reviewed
Feb 20, 2022
Comment on lines
53
to
65
| .header-text { | ||
| /* stylelint-disable property-no-vendor-prefix */ | ||
| /* stylelint-disable value-no-vendor-prefix */ | ||
| display: -webkit-box; | ||
| overflow: hidden; | ||
| flex-grow: 1; | ||
| -webkit-box-orient: vertical; | ||
| -webkit-line-clamp: 2; | ||
| /* stylelint-enable property-no-vendor-prefix */ | ||
| /* stylelint-enable value-no-vendor-prefix */ | ||
| margin-inline-end: auto; | ||
| text-align: left; | ||
| } |
There was a problem hiding this comment.
what's this for? are we allowing more than a single line for heading?
There was a problem hiding this comment.
Yes. up to 2 lines as. Joella said
There was a problem hiding this comment.
can we extract this to another issue/PR?
yinonov
suggested changes
Feb 22, 2022
yinonov
reviewed
Feb 27, 2022
yinonov
previously approved these changes
Feb 27, 2022
yinonov
approved these changes
Feb 28, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a caption above the header textremoved from this PRwrapped the expansion-panel button with H3 - considering wether it's too generic and we need to set is as default with an option to change the headline number according to the component position in the page hierarchy.moved to 1228