Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popup] fix start open position #1234

Closed
rinaok opened this issue Feb 8, 2022 · 0 comments · Fixed by #1236
Closed

[Popup] fix start open position #1234

rinaok opened this issue Feb 8, 2022 · 0 comments · Fixed by #1236
Assignees
@rinaok @yinonov
Labels
Type: Bug 🐞 Something isn't working Type: Component 🛠 Assigned to PRs delivering brand-new components to the Vivid catalog

Comments

@rinaok
Copy link
Contributor

rinaok commented Feb 8, 2022 •
edited

When the Popup is first time loaded, if it's open, it's not positioned correctly.
To reproduce - add <vwc-popup open anchor="buttonAnchor"></vwc-popup>

An UI test must be added.
@rinaok rinaok self-assigned this Feb 8, 2022
@rinaok rinaok added Type: Bug 🐞 Something isn't working Type: Component 🛠 Assigned to PRs delivering brand-new components to the Vivid catalog labels Feb 8, 2022
YonatanKra added a commit that referenced this issue Feb 13, 2022
@YonatanKra
fix(popup): now watching anchor size for position correctness
33a9e12 
Closes #1234
@YonatanKra YonatanKra mentioned this issue Feb 13, 2022
Merged
rinaok added a commit that referenced this issue Feb 15, 2022
@YonatanKra @rinaok
fix(popup): now watching anchor size for position correctness (#1236)
755c072 
* fix(popup): now watching anchor size for position correctness

Closes #1234

* Linting fixes

* update story

* Fix the tests

* Fix linting

* Refactor tests

Co-authored-by: Rina <rina.oksman@vonage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rinaok rinaok

@yinonov yinonov

Labels
Type: Bug 🐞 Something isn't working Type: Component 🛠 Assigned to PRs delivering brand-new components to the Vivid catalog
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(popup): now watching anchor size for position correctness Vonage/vivid
2 participants
@rinaok @yinonov