fix(popup): now watching anchor size for position correctness #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Latest successful build of the PR deployed here. 🚀 |
YonatanKra
changed the title
rinaok
previously approved these changes
Feb 13, 2022
…into try-to-fix-popup-rc
yinonov
reviewed
Feb 13, 2022
| @@ -4,9 +4,9 @@ import 'chai-dom'; | |||
| import { | |||
| waitNextTask, | |||
| textToDomToParent, | |||
| isolatedElementsCreation, | |||
| isolatedElementsCreation, waitInterval, noop, | |||
There was a problem hiding this comment.
Maybe not. Don't we have a linting rule that should fail if unused variable?
Anyway - if it doesn't appear in the code, it can be removed.
@YonatanKra Not stable :(
|
rinaok
requested changes
Feb 14, 2022
I'll try to look at it tonight. Can't promise... |
rinaok
approved these changes
Feb 15, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1234