Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Empty-state] Add graphic slot #1320

Closed
jshenkman opened this issue Jun 22, 2022 · 0 comments · Fixed by #1322
Closed

[Empty-state] Add graphic slot #1320

jshenkman opened this issue Jun 22, 2022 · 0 comments · Fixed by #1322
Assignees
@yinonov
Labels
Type: Design 🎨

Comments

@jshenkman
Copy link
Contributor

jshenkman commented Jun 22, 2022 •
edited

Empty state is composed of 3 parts -

  1. Media - Icon + circle background
  2. Heading
  3. Body

Designers asked for the option to put illustrations in the media instead of a simple icon. We decided to allow this using a media slot.

Thanks :)
yinonov added a commit that referenced this issue Jun 22, 2022
@yinonov
feat(empty-state): support graphic assigned node
dd9b77b 
Closes #1320
@yinonov yinonov mentioned this issue Jun 22, 2022
Merged
8 tasks
yinonov added a commit that referenced this issue Jul 1, 2022
@yinonov
feat(empty-state): support graphic assigned node (#1322)
bde72fd 
* feat(empty-state): support graphic assigned node

Closes #1320

* snapshot

* snapshot?

* redundant test

* remove unused imports

* remove unit test styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yinonov yinonov

Labels
Type: Design 🎨
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(empty-state): support graphic assigned node Vonage/vivid
2 participants
@yinonov @jshenkman