Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): icons misaligned in the new implementation #637

Closed
gullerya opened this issue Feb 5, 2021 · 0 comments · Fixed by #638
Closed

fix(icon): icons misaligned in the new implementation #637

gullerya opened this issue Feb 5, 2021 · 0 comments · Fixed by #638
Assignees
@gullerya
Labels
Type: Bug 🐞 Something isn't working

Comments

@gullerya
Copy link
Contributor

gullerya commented Feb 5, 2021

After moving to the new implementation the icons are misplaced.
@gullerya gullerya added the Type: Bug 🐞 Something isn't working label Feb 5, 2021
@gullerya gullerya self-assigned this Feb 5, 2021
@gullerya gullerya mentioned this issue Feb 5, 2021
Merged
gullerya added a commit that referenced this issue Feb 5, 2021
@gullerya
issue #637: CR remarks
17849c5
gullerya added a commit that referenced this issue Feb 5, 2021
@gullerya @yinonov @JoelGraham93
fix(icon): issue 637 fixing icon misplacement (#638)
2de7e94 
* issue 637: fixing icon misplacement

* Update components/icon/src/vwc-icon.scss

Co-authored-by: yinon <yinon@hotmail.com>

* issue 637: icon css fixes

* issue 637: icon css fixes

* fixing lint ignore patterns

* issue 637: CR remarks

* issue #637: CR remarks

* align all instances of vwc-icon with new structure

* update icon-button snapshot

Co-authored-by: yinon <yinon@hotmail.com>
Co-authored-by: joelgraham93 <j.r.g@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gullerya gullerya

Labels
Type: Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(icon): issue 637 fixing icon misplacement Vonage/vivid
1 participant
@gullerya