feat(action-group): new component #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Latest successful build of the PR deployed here. 🚀 |
yinonov
suggested changes
Jun 8, 2022
| const ActionGroupTightTemplate = args => html` | ||
| <div style="display: flex; column-gap: 2px"> | ||
| <vwc-action-group ...=${spread(args)}> | ||
| <vwc-button icon="flag-uruguay"> |
There was a problem hiding this comment.
why not having an actual select? here it's possible
There was a problem hiding this comment.
you mean an additional nested action-group that contain icon + select (for the +1)?
YonatanKra
force-pushed
the
action-group-component
branch
from
5b6cff8
to
6ce27e1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
yinonov
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.