Skip to content

Commit

Permalink
more explicit class name
Browse files Browse the repository at this point in the history
  • Loading branch information
SecondeJK committed Jun 28, 2023
1 parent ec91718 commit 1542a70
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/Subaccount/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Vonage\Entity\Filter\FilterInterface;
use Vonage\Entity\Hydrator\ArrayHydrator;
use Vonage\Subaccount\Request\NumberTransferRequest;
use Vonage\Subaccount\Request\TransferRequest;
use Vonage\Subaccount\Request\TransferCreditRequest;
use Vonage\Subaccount\SubaccountObjects\Account;
use Vonage\Subaccount\SubaccountObjects\BalanceTransfer;
use Vonage\Subaccount\SubaccountObjects\CreditTransfer;
Expand Down Expand Up @@ -63,14 +63,14 @@ public function createSubaccount(string $apiKey, array $payload): ?array
return $this->api->create($payload, '/' . $apiKey . '/subaccounts');
}

public function makeBalanceTransfer(TransferRequest $transferRequest): BalanceTransfer
public function makeBalanceTransfer(TransferCreditRequest $transferRequest): BalanceTransfer
{
$response = $this->api->create($transferRequest->toArray(), '/' . $transferRequest->getApiKey() . '/balance-transfers');

return (new BalanceTransfer())->fromArray($response);
}

public function makeCreditTransfer(TransferRequest $transferRequest): CreditTransfer
public function makeCreditTransfer(TransferCreditRequest $transferRequest): CreditTransfer
{
$response = $this->api->create($transferRequest->toArray(), '/' . $transferRequest->getApiKey() . '/credit-transfers');
return (new CreditTransfer())->fromArray($response);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Vonage\Entity\Hydrator\ArrayHydrateInterface;

class TransferRequest implements ArrayHydrateInterface
class TransferCreditRequest implements ArrayHydrateInterface
{
private string $from;
private string $to;
Expand Down
6 changes: 3 additions & 3 deletions test/Subaccount/ClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
use Vonage\Subaccount\Client as SubaccountClient;
use Vonage\Subaccount\Filter\SubaccountFilter;
use Vonage\Subaccount\Request\NumberTransferRequest;
use Vonage\Subaccount\Request\TransferRequest;
use Vonage\Subaccount\Request\TransferCreditRequest;
use Vonage\Subaccount\SubaccountObjects\Account;
use Vonage\Subaccount\SubaccountObjects\BalanceTransfer;
use Vonage\Subaccount\SubaccountObjects\CreditTransfer;
Expand Down Expand Up @@ -217,7 +217,7 @@ public function testWillTransferCredit(): void
return true;
}))->willReturn($this->getResponse('make-credit-transfer-success'));

$transferRequest = (new TransferRequest($apiKey))
$transferRequest = (new TransferCreditRequest($apiKey))
->setFrom($payload['from'])
->setTo($payload['to'])
->setAmount($payload['amount'])
Expand Down Expand Up @@ -316,7 +316,7 @@ public function testCanTransferBalance(): void
return true;
}))->willReturn($this->getResponse('make-balance-transfer-success'));

$balanceTransferRequest = (new TransferRequest($apiKey))
$balanceTransferRequest = (new TransferCreditRequest($apiKey))
->setTo('s5r3fds')
->setFrom('acc6111f')
->setAmount('123.45')
Expand Down

0 comments on commit 1542a70

Please sign in to comment.