Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Both Psr7Trait and JsonResponseTrait define the same $response property. #2

Closed
crynobone opened this issue May 10, 2016 · 2 comments
Closed

[Bug] Both Psr7Trait and JsonResponseTrait define the same $response property. #2

crynobone opened this issue May 10, 2016 · 2 comments

Comments

@crynobone
Copy link
Contributor

exception 'ErrorException' with message 'Nexmo\Entity\Psr7Trait and Nexmo\Entity\JsonResponseTrait define the same property ($response) in the composition of Nexmo\Message\Message. This might be incompatible, to improve maintainability consider using accessor methods in traits instead. Class was composed
@crynobone crynobone mentioned this issue May 10, 2016
Merged
@crynobone
Copy link
Contributor Author

screen shot 2016-05-13 at 9 25 25 pm

@tjlytle
Copy link
Contributor

tjlytle commented May 13, 2016

Good catch, the traits are a bit fluid at this point, should solidify soon. Trying to bridge compatibility with the existing APIs, and more REST-like future APIs.

@tjlytle tjlytle closed this as completed May 13, 2016
@JanieQ JanieQ mentioned this issue Dec 10, 2016
Closed
@topart1 topart1 mentioned this issue Jan 7, 2017
Closed
@ahmedhashmi21 ahmedhashmi21 mentioned this issue Aug 11, 2017
Closed
@ahmedhashmi21 ahmedhashmi21 mentioned this issue Nov 28, 2017
Closed
@sjavamaster1 sjavamaster1 mentioned this issue Mar 12, 2018
Closed
@NEST387 NEST387 mentioned this issue Feb 23, 2019
Closed
@dragonmantank dragonmantank mentioned this issue Oct 14, 2020
Merged
dragonmantank added a commit that referenced this issue Apr 26, 2021
@dragonmantank
Merge pull request #2 from Nexmo/nexmo/migration
f3548d0 
Added migration notes for moving to vonage packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tjlytle @crynobone