Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NEXMO_ references to VONAGE_ in README.md #254

Conversation

GregHolmes
Copy link
Contributor

Due to the Rebrand, references to NEXMO have been updated to Vonage. This includes the placeholders where users are instructed to replace the values with their own unique values

Description

Updated all references to NEXMO_ placeholders with VONAGE_ placeholders

Motivation and Context

This problem continues the process of the SDK rebrand from Nexmo to Vonage

How Has This Been Tested?

No code needs testing, I have viewed the changes through a markdown previewer however.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Due to the Rebrand, references to NEXMO have been updated to Vonage. This includes the placeholders where users are instructed to replace the values with their own unique values
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #254   +/-   ##
=========================================
  Coverage     80.31%   80.31%           
  Complexity     2396     2396           
=========================================
  Files           166      166           
  Lines          6072     6072           
=========================================
  Hits           4877     4877           
  Misses         1195     1195           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a397028...790c575. Read the comment docs.

@dragonmantank dragonmantank merged commit 7a04876 into Vonage:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants