Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated code - unserialize, dead imports. #313

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Removed deprecated code - unserialize, dead imports. #313

merged 1 commit into from
Apr 21, 2022

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Apr 19, 2022 •
edited
Loading

A Smaller PR to clean up some leftover code from the v3.0 release.

Description

  • Removal of unserialize. It's dangerous, and should not be present anywhere in the code.
  • Removal of unused function imports in the base Client
  • Removal of dead imports from deprecated Clients

Motivation and Context

Housekeeping

How Has This Been Tested?

One call to unserialize has been removed from the test suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

matt-lethargic
matt-lethargic approved these changes Apr 19, 2022
View reviewed changes
Copy link

@matt-lethargic matt-lethargic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SecondeJK SecondeJK merged commit 8ffaa3e into main Apr 21, 2022
@ExpDev07
Copy link

ExpDev07 commented Apr 25, 2022 •
edited
Loading

This PR broke https://github.com/laravel/vonage-notification-channel. See laravel/vonage-notification-channel#59 @matt-lethargic @SMadani.

@SecondeJK SecondeJK deleted the chore/quick-housekeeping branch May 3, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-lethargic matt-lethargic matt-lethargic approved these changes

@SMadani SMadani SMadani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SecondeJK @ExpDev07 @matt-lethargic @SMadani