Change warning to logger for GSM-7 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #382 +/- ##
============================================
- Coverage 78.31% 78.26% -0.06%
- Complexity 1818 1820 +2
============================================
Files 172 172
Lines 4875 4872 -3
============================================
- Hits 3818 3813 -5
- Misses 1057 1059 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
manchuck
requested changes
Mar 3, 2023
SMadani
approved these changes
Mar 3, 2023
manchuck
approved these changes
Mar 3, 2023
dragonmantank
requested changes
Mar 3, 2023
Co-authored-by: Chris Tankersley <chris@ctankersley.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been through several implementations of this, and I think we're at a final one for the behaviour of sending an SMS that can be used by frameworks effectively.
Description
If you have chosen to set your SMS as unicode, it will no longer issue a warning if it contains a GSM-7 charset: you have explicitly told the code that you want to send it as unicode because it is not the default.
If you are sending a message that should be in unicode, but have not changed the type, a log warning will be fired if you have set a logger up for the library. We don't want to stop you sending the message - it might be garbled, but it's your choice to send it this way if you wish. To prevent this, make sure to use the
isGsm7static method on the SMS object.Motivation and Context
Trying to get the best user experience we can (and it's hard)
How Has This Been Tested?
One test deleted, the other changed to use prophecy to test the call to the logger.
Types of changes
Checklist: