Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getRecording for Voice, URL Override #413

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

SecondeJK
Copy link
Contributor

This contains an important bug fix for Voice

Description

The original release of getRecording() in the Voice client would still contain the baseURL and baseUri inherited from the APIResource configuration.

getRecording() needs the edge case ability to take any URL it's given (from the voice webhook containing a download URL) and apply Vonage credentials to it.

Motivation and Context

The Vonage Helpdesk project has identified this as a major bug. We also want to phase out users using the old base Vonage client get() method as Auth is all handled within configurable APIResource objects.

How Has This Been Tested?

Fixed the test, which was one of the primary failures to identify this as it was testing the path stitched together with the baseURL and uri.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…se where region URL is different from REST base URL
@codecov-commenter
Copy link

Codecov Report

Merging #413 (aead0bb) into main (5d59b3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #413   +/-   ##
=========================================
  Coverage     77.60%   77.61%           
- Complexity     1962     1963    +1     
=========================================
  Files           191      191           
  Lines          5221     5223    +2     
=========================================
+ Hits           4052     4054    +2     
  Misses         1169     1169           
Impacted Files Coverage Δ
src/Client/APIResource.php 93.30% <100.00%> (+0.06%) ⬆️
src/Voice/Client.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SecondeJK SecondeJK merged commit fd72359 into main Jun 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants