Fix getRecording for Voice, URL Override #413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains an important bug fix for Voice
Description
The original release of
getRecording()
in the Voice client would still contain the baseURL and baseUri inherited from the APIResource configuration.getRecording()
needs the edge case ability to take any URL it's given (from the voice webhook containing a download URL) and apply Vonage credentials to it.Motivation and Context
The Vonage Helpdesk project has identified this as a major bug. We also want to phase out users using the old base Vonage client
get()
method as Auth is all handled within configurableAPIResource
objects.How Has This Been Tested?
Fixed the test, which was one of the primary failures to identify this as it was testing the path stitched together with the baseURL and uri.
Types of changes
Checklist: