Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to do numbers filtering with has_application and application_id filters #448

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

erickskrauch
Copy link
Contributor

Description

Those two filters are listed here, but not available in this library. My PR fixes that.

Motivation and Context

My company need that.

How Has This Been Tested?

I have tested it by searching purchased phone numbers with those filters.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK SecondeJK self-assigned this Oct 24, 2023
@SecondeJK SecondeJK added the bug label Oct 24, 2023
Copy link
Contributor

@SecondeJK SecondeJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great enhancement for some missing functionality, thank you!

@SecondeJK SecondeJK merged commit 915a62f into Vonage:main Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants