Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add optional redirect url #454

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Nov 14, 2023

This PR allows Verify v2 requests for Silent Auth to go out with the optional redirect_url

Description

The option modifies the VerificationWorkflow object to allow custom keys to be added (which are likely to be soon used in other Verify channels)

Motivation and Context

New parameter that is already available

How Has This Been Tested?

New test added to make sure that the outgoing response has the correct key

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SecondeJK SecondeJK merged commit 5021494 into main Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants