Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From can now be added for sender_id on Verify2 SMS #461

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Dec 13, 2023

Description

This patch adds from as a field for Verify2 SMS

Motivation and Context

Sender_ID parity requirements with Verify legacy

How Has This Been Tested?

existing tests modified to check it gets sent out in the request

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bac6ebc) 78.94% compared to head (2861f85) 77.95%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/Verify2/VerifyObjects/VerificationWorkflow.php 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #461      +/-   ##
============================================
- Coverage     78.94%   77.95%   -0.99%     
- Complexity     2331     2382      +51     
============================================
  Files           218      218              
  Lines          6264     6397     +133     
============================================
+ Hits           4945     4987      +42     
- Misses         1319     1410      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SecondeJK SecondeJK merged commit b903787 into main Dec 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants