Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Entity ID and Content ID to Verify V2 #464

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Jan 16, 2024

This PR adds two new optional fields into the SMS Workflow for Verify.

Description

entity_id and content_id can now be passed into the SMSWorkflow for 2FA processes using Indian carriers.

Motivation and Context

Parity for Vonage APIs

How Has This Been Tested?

New test added to make sure the request is made with the new keys.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0cd476) 79.01% compared to head (7a02496) 79.02%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #464      +/-   ##
============================================
+ Coverage     79.01%   79.02%   +0.01%     
  Complexity     2337     2337              
============================================
  Files           218      218              
  Lines          6281     6285       +4     
============================================
+ Hits           4963     4967       +4     
  Misses         1318     1318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +125 to +126
'client_ref' => 'my-verification',
'brand' => 'my-brand',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused here because brand and client_ref are top-level fields, whilst the others should be wrapped in a workflow object.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for readability of the test code, nothing more. "Here is the test array, the code will put it in the right places"

@SecondeJK SecondeJK merged commit c412306 into main Jan 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants