New Messages API Features

[SecondeJK]

This PR provides parity with new Messages API features.

Description

webhook_url and webhook_version have been added to all Messages API Objects
sms property added to outbound SMS text objects, containing encoding_type, content_id, entity_id and ttl
MMS vCard now has caption
WhatsApp File object now has name

Fixed the Viber Video object which was missing the viber_service object, but now has mandatory duration and file_size keys

Motivation and Context

Parity with Vonage APIs

How Has This Been Tested?

Existing tests have been modified

Example Output or Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[superchilled]

Looks good overall. I just had a question about Messages/MessageObjects. Are the same objects (and therefore properties) used across different channels? For example, with FileObject, the __construct function can set properties on the object for url, caption, and name, which is fine for a WhatsApp file message (which can include all three properties), but not a Viber file message, which only has url and name.

From my understanding of the code, it looks like it would be possible to construct a Viber file message which included a caption property (which would then result in error on the API side). Or perhaps I'm missing something in my understanding of __construct?

[SecondeJK]

@superchilled That's true: you could actually send a file object with the caption for Viber - the way it works is with default values so that it's up to the user to populate the object correctly.

As the channels become more complex, I might introduce a validation set of classes. I don't want to extend the file objects for every channel - there's already more objects than I'd like. But with a validator, it could decorate them to say "you've done it wrong"

[superchilled]

@superchilled That's true: you could actually send a file object with the caption for Viber - the way it works is with default values so that it's up to the user to populate the object correctly.

As the channels become more complex, I might introduce a validation set of classes. I don't want to extend the file objects for every channel - there's already more objects than I'd like. But with a validator, it could decorate them to say "you've done it wrong"

Thanks Jim. That makes sense! :)