Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insight to return data when it is chargeable #466

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Feb 6, 2024

Number Insight API Handling currently throws exceptions when it shouldn't.

Description

Due to the design of NIv1, 43, 44 and 45 status codes are chargeable and therefore the client should return the partial data that has been returned.

Motivation and Context

Arose from #463

How Has This Been Tested?

Complete tests were not available for NI. I have added suitable API call mocks.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b0306e) 79.12% compared to head (76a6559) 79.18%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #466      +/-   ##
============================================
+ Coverage     79.12%   79.18%   +0.05%     
  Complexity     2371     2371              
============================================
  Files           218      218              
  Lines          6353     6356       +3     
============================================
+ Hits           5027     5033       +6     
+ Misses         1326     1323       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SecondeJK SecondeJK merged commit 8cc9df0 into main Feb 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants