Add sorbet types to some modules #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ohbarye, so glad to see your PR on this! I'll take a look this week. Thanks for contributing! |
hummusonrails
suggested changes
Oct 14, 2020
There was a problem hiding this comment.
This looks great, @ohbarye! I've left just a couple small suggestions to incorporate.
Vonage#180 (comment) Co-authored-by: Ben Greenberg <13892277+bencgreenberg@users.noreply.github.com>
Vonage#180 (comment) Co-authored-by: Ben Greenberg <13892277+bencgreenberg@users.noreply.github.com>
|
@bencgreenberg Thanks for your review, I've addressed them. |
|
LGTM 👍 |
hummusonrails
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bencgreenberg
Thanks for giving me a chance to contribute.
I'm so new to Sorbet, please let me know if this change has anything wrong.
Issue
Part of #178
Changes
Added Sorbet typings to the modules below.
Vonage::UserAgentVonage::GSM7